Startup: Add ES_HOME to ES_INCLUDE search path #4958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spinscale please could you take a look at this |
spinscale
pushed a commit
that referenced
this pull request
Oct 22, 2014
With this change, the elasticsearch script can be linked to another path without having to set ES_INCLUDE to match the installation path. Previously, the elasticsearch would find ES_HOME correctly even if linked but could not find the include script, and finding it would be expected behavior to me based on its current search path. Closes #4958
spinscale
changed the title
clintongormley
added
the
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the elasticsearch script can be linked to another path without having to set ES_INCLUDE to match the installation path. Previously, the elasticsearch would find ES_HOME correctly even if linked but could not find the include script, and finding it would be expected behavior to me based on its current search path.
I'm going straight to a pull request on this, as it's a minor improvement to the executable and solutions to ES_INCLUDES are generally workarounds listed on closed issues.