AssertionError during percolation using constant score query

[imotov]

When elasticsearch is running with assertions enabled, a constant score query that doesn't match a record can cause AssertionError to be thrown. To reproduce start elasticsearch with assertions enabled and execute the following script

on 0.90 branch:

curl -XDELETE localhost:9200/test-idx
curl -XPUT 'localhost:9200/test-idx/'
curl -XPUT 'localhost:9200/_percolator/test-idx/1' -d '{
    "query" : {
        "constant_score":{
            "filter": {
                "and": [{
                    "query": {
                        "query_string" : {
                            "query" : "root"
                        }
                    }
                }, {
                    "term" : {
                        "message" : "tree"
                    }
                }]
            }
        }
    }
}'
curl -XGET 'localhost:9200/test-idx/message/_percolate' -d '{
    "doc" : {
        "message" : "A new bonsai tree in the office"
    }
}'

to reproduce on master:

curl -XDELETE localhost:9200/test-idx
curl -XPUT 'localhost:9200/test-idx/.percolator/1' -d '{
    "query" : {
        "constant_score":{
            "filter": {
                "and": [{
                    "query": {
                        "query_string" : {
                            "query" : "root"
                        }
                    }
                }, {
                    "term" : {
                        "message" : "tree"
                    }
                }]
            }
        }
    }
}'
curl -XGET 'localhost:9200/test-idx/message/_percolate' -d '{
    "doc" : {
        "message" : "A new bonsai tree in the office"
    }
}'

On the master the issue is not as prominent since the error is not returned to the user. On the current master the result of execution of the script above is the following error in the log:

[2014-02-07 10:49:32,594][WARN ][percolator               ] [Blizzard II] [[31]] failed to execute query
java.lang.AssertionError
    at org.apache.lucene.search.Scorer.score(Scorer.java:61)
    at org.apache.lucene.search.ConstantScoreQuery$ConstantScorer.score(ConstantScoreQuery.java:256)
    at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:621)
    at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:309)
    at org.elasticsearch.percolator.PercolatorService$4.doPercolate(PercolatorService.java:543)
    at org.elasticsearch.percolator.PercolatorService.percolate(PercolatorService.java:232)
    at org.elasticsearch.action.percolate.TransportPercolateAction.shardOperation(TransportPercolateAction.java:194)
    at org.elasticsearch.action.percolate.TransportPercolateAction.shardOperation(TransportPercolateAction.java:55)
    at org.elasticsearch.action.support.broadcast.TransportBroadcastOperationAction$AsyncBroadcastAction$2.run(TransportBroadcastOperationAction.java:226)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:724)