Fix AndDocIdSet#IteratorBasedIterator to not violate initial doc state #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| IteratorBasedIterator(DocIdSet[] sets) throws IOException { | ||
| iterators = new DocIdSetIterator[sets.length]; | ||
|
|
||
| public static DocIdSetIterator newDocIdSet(DocIdSet[] sets) throws IOException { |
There was a problem hiding this comment.
maybe the method should be named newDocIdSetIterator?
|
+1 In addition to fixing the bug, I think this makes the iterator creation much better! |
|
@jpountz pushed a new commit |
|
+1 |
AndDocIdSet#IteratorBasedIterator was potentially initialized with NO_MORE_DOCS which violates the initial state of DocIdSetIterator and could lead to undefined behavior when used in a search context. Closes elastic#5049
clintongormley
added
the
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AndDocIdSet#IteratorBasedIterator was potentially initialized with
NO_MORE_DOCS which violates the initial state of DocIdSetIterator and
could lead to undefined behavior when used in a search context.
Closes #5049