[Java API] IdsQueryBuilder allow merging with list

[nfx]

Currently IdsQueryBuilder does support only appending arrays of identifiers and converting them to lists:

public IdsQueryBuilder addIds(String... ids) {
        values.addAll(Arrays.asList(ids));
        return this;
    }

In cases of huge numbers of IDs submitted to builder it could be more wise of performance to merge with lists directly. Or are there any better ideas?

[spinscale]

Hey,

I am not sure I follow your request. Can you explain, which performance exactly you intend to improve? Right now the datastructure used there is a list. We could possibly use a set to prevent duplicate or use a HPPC collection to be more garbage collection friendly/faster. Is this what you mean with better merging performance?

Also wondering how much ids you intend to put into a single request. Keep in mind, that you will need to get the data from elasticsearch and return it to the client. It might not be a good idea to get several million entries per request.

Any helping comments are greatly appreciated here! Thanks a lot!

[nfx]

It's just for the ease of use - applications collect ids as lists and it's easier to pass them directly inside of method calls