Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserve original token option to ASCIIFolding #5115

Closed
wants to merge 1 commit into from

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Feb 13, 2014

Closes #4931

@s1monw
Copy link
Contributor

s1monw commented Feb 13, 2014

LGTM I will pull this one in tomorrow

@s1monw s1monw self-assigned this Feb 13, 2014
@s1monw
Copy link
Contributor

s1monw commented Feb 14, 2014

@nik9000 I just saw that the docs change doesn't include a coming tag can you add that like this:

diff --git a/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc b/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc
index 7de1711..911ba7e 100644
--- a/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc
+++ b/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc
@@ -20,8 +20,8 @@ equivalents, if one exists.  Example:
 }
 --------------------------------------------------

-Accepts `preserve_original` setting which defaults to false but if true
-will keep the oringal token as well as emit the folded token.  For
+coming[1.1.0, Accepts `preserve_original` setting which defaults to false but if true
+will keep the oringal token as well as emit the folded token.]  For
 example:

 [source,js]

this allows us to mark changes in the docs with the version they were added

@nik9000
Copy link
Member Author

nik9000 commented Feb 14, 2014

Yeah! I'll get to it in an a couple hours.

Sent from my iPhone

On Feb 14, 2014, at 4:34 AM, Simon Willnauer notifications@github.com wrote:

@nik9000 I just saw that the docs change doesn't include a coming tag can you add that like this:

diff --git a/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc b/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc
index 7de1711..911ba7e 100644
--- a/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc
+++ b/docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc
@@ -20,8 +20,8 @@ equivalents, if one exists. Example:
}


-Accepts preserve_original setting which defaults to false but if true
-will keep the oringal token as well as emit the folded token. For
+coming[1.1.0, Accepts preserve_original setting which defaults to false but if true
+will keep the oringal token as well as emit the folded token.] For
example:

[source,js]
this allows us to mark changes in the docs with the version they were added


Reply to this email directly or view it on GitHub.

@s1monw
Copy link
Contributor

s1monw commented Feb 14, 2014

Yeah! I'll get to it in an a couple hours.
no worries - no rush

@nik9000
Copy link
Member Author

nik9000 commented Feb 14, 2014

Done.

@s1monw
Copy link
Contributor

s1monw commented Feb 14, 2014

pushed thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asciifolding filter emit original token
3 participants