Exposed shard id related to a failure in delete by query #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but it would be nice to add asserts to DeleteByQueryTests#testFailure to make sure that shard >= 0 in response.failures, since this is the part that you fixed. |
|
Makes sense, applied changes suggested by @imotov. |
…ose the shard id related to a shard failure The `ShardOperationFailedException` is now created within `TransportIndexReplicationAction` passing in the current shard id as a constructor argument. Also replaced `AtomicReferenceArray<Object>` with `AtomicReferenceArray<ShardActionResult>`, where `ShardActionResult` wraps the `ShardResponse` or the failure, containing all the needed info.
|
LGTM |
clintongormley
added
the
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5095, where we want to expose the potential shard failures obtained from the delete by query api. Although the failure is available, the shard id where it happened is not (always
-1).Refactored TransportIndexReplicationOperationAction to be able to expose the shard id related to a shard failure.
The
ShardOperationFailedExceptionis now created withinTransportIndexReplicationActionpassing in the current shard id as a constructor argument.Also replaced
AtomicReferenceArray<Object>withAtomicReferenceArray<ShardActionResult>, whereShardActionResultwraps theShardResponseor the failure, containing all the needed info.