Togglable stacktrace display #5187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you could get this by setting bootstrap level logging to DEBUG, right? @imotov maybe I am missing something? |
|
@kimchy yes you can get it, but only in the log file. When you run it in foreground you only get error message. I guess we could piggy back on the bootstrap:DEBUG setting and use it in foreground as well. So, it would console output and log would be consistent. |
|
@imotov ++, makes sense. |
|
Thankyou for the comments! Is this what we're after, then? |
|
@timorantalaiho something similar, just without changing the default bootstrap category to DEBUG |
This makes it a lot easier to debug a problem like
{2.0.0-SNAPSHOT}: Startup Failed ...
- NumberFormatException[For input string: ""]
because now you see from where the error comes from (which might be from
a plugin!).
Whether or not the stacktrace is displayed is controlled by bootstrap
log level setting, so that bootstrap: DEBUG displays the stack trace on
output, like it does on log, as suggested by @imotov
elastic#5187 (comment)
|
All right, removed it even though I as an ES user would greatly appreciate getting the stack traces of startup by default :) |
|
Merged, thanks @timorantalaiho !! |
clintongormley
added
>enhancement
v2.0.0-beta1
v1.2.0
:Core/Infra/Logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it flaggable with system property whether ES will display
only Throwable message or full stack trace on startup, as
suggested by @imotov in #5103 discussion. Defaults to
displaying stack trace, but it can be suppressed by
-Des.suppress-stack-traces=true.Closes #5102