Be less verbose logging ClusterInfoUpdateJob failures #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch results in no chance (not even with another loglevel) to access the stack trace anymore. Is that ok for this case? |
|
@spinscale good idea, I decided to change this to log the full exception if trace logging is enabled, at the trace level. |
dakrone
added a commit
that referenced
this pull request
Mar 27, 2014
|
can we re-open this? I think its cleaner to warn log the full exception, bug if the exception is a cluster block exception (for example, during startup), simply trace log it. |
|
@kimchy sure, I'll make that change. |
clintongormley
added
>enhancement
:Core/Infra/Logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.