Make sure get field mapping request is executed on node hosting the index #5225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relevant indices. This is due to the fact that have to have mappers in order to return the response. Closes elastic#5177
… that has a master only node.
…ould hang forever)
…ustomOperationAction as base class, with the goal to reuse common logic (like: retry on failures, shard picking, connecting to nodes)
| @@ -62,6 +126,14 @@ public ActionRequestValidationException validate() { | |||
| @Override | |||
| public void writeTo(StreamOutput out) throws IOException { | |||
| super.writeTo(out); | |||
| if (out.getVersion().onOrBefore(Version.V_1_0_0)) { | |||
There was a problem hiding this comment.
I think we should always write / read a default and remove the line entirely in master. So master doesn't know about this at all and 0.90 / 1.x / 1.0 will just write / read dummy values and ignore the actual value.
|
this PR LGTM I think you should push it and add some lines to the issue that this might barf during rolling upgrades. |
|
Merged in. |
clintongormley
added
>bug
v1.0.1
v1.1.0
v2.0.0-beta1
v0.90.12
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #5177