Rewrite BytesStreamOutput on top of BigArrays/ByteArray. #5331
Conversation
| ensureOpen(); | ||
|
|
||
| // shrink list of pages | ||
| bytes = bigarrays.resize(bytes, BigArrays.PAGE_SIZE_IN_BYTES); |
There was a problem hiding this comment.
if the size was previously less than PAGE_SIZE_IN_BYTES (possible with the contructor that exposes a size), this will actually grow the array (potentially going from a simple heap-allocated byte[] wrapper to a recycling instance)
There was a problem hiding this comment.
Maybe it could be something like:
if (bytes.size() > BigArrays.PAGE_SIZE_IN_BYTES) {
bytes = bigarrays.resize(bytes, BigArrays.PAGE_SIZE_IN_BYTES);
}
There was a problem hiding this comment.
The default constructor requests at least a single page, so this is simply symmetric. No important client calls this at the moment.
There was a problem hiding this comment.
Then I'd rather remove this method, because if they start using it, it will have surprising behavior (I would never expect memory to be allocated in a method called reset)
|
This looks good to me now! +1 to push |
Make BytesStreamOutput more efficient by using paging via BigArrays/ByteArrays. Also changes two existing callers to be more correct/efficient.
Fix for #5159