Invoke postCollection on aggregation collectors #5387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PercolatorFacetsAndAggregationsTests class with this PR applied works fine on the development branch for aggs where calling Aggregator.postCollection() is critical and was failing previously. Thanks, @martijnvg . |
Also cleanup how facet and aggs collector are used inside the QueryCollector Closes elastic#5387
martijnvg
added a commit
that referenced
this pull request
Mar 13, 2014
Also cleanup how facet and aggs collector are used inside the QueryCollector Closes #5387
martijnvg
added a commit
that referenced
this pull request
Mar 13, 2014
Also cleanup how facet and aggs collector are used inside the QueryCollector Closes #5387
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Also cleanup how facet and aggs collector are used inside the QueryCollector Closes elastic#5387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleanup how facet and aggs collector are used inside the QueryCollector