Make aggregations CacheRecycler-free. #5419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggregations were still using CacheRecycler on the reduce phase. They are now using page-based recycling for both the aggregation phase and the reduce phase. Close elastic#4929
| /** | ||
| * Base implementation for a hash table that recycles arrays and grows in-place. | ||
| */ | ||
| abstract class AbstractHashTable implements Releasable { |
There was a problem hiding this comment.
maybe rename this to AbstractReleasableHash ?
There was a problem hiding this comment.
I wouldn't do that - it already is a Releasable so we don't need to put it in the name
|
Agree, in this case it doesn't really embodies the purpose of this class... Maybe |
|
Oops |
|
As I was saying.... Maybe AbstractPagedHash? I just want to move it away as far as possible from java collections names |
|
@uboness just added a commit following your recommendation |
|
wonderful! |
|
LGTM! +1 |
clintongormley
added
>enhancement
v1.1.0
v2.0.0-beta1
:Analytics/Aggregations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregations were still using CacheRecycler on the reduce phase. They are now
using page-based recycling for both the aggregation phase and the reduce phase.
Close #4929