Remove Releasable in favor of Closeable

[s1monw]

given that we are moving to Java 1.7 when Lucene 4.8 lands (#5421) we should take advantage of try-with statements and use Closeable instead since it's bascially the same thing!

[uboness]

+1

[jpountz]

Or should it be just AutoCloseable instead of Closeable? Javadocs suggest that Closeable.close needs to be idempotent while AutoCloseable.close doesn't and I think it makes sense to throw errors upon double-release (as it quite likely suggests a programming error)?

[uboness]

Not sure I agree... Sometimes you just want to make sure something is closed even if there's a chance it's already closed... We should be lenient there

[uboness]

We can use assertion for ensuring things are closed once

[s1monw]

I think it's good to use AutoCloseable since we can then throw already closed exceptiosn? I like the idea - I guess we should have a base class that makes sure the actual releaseing is only happening once?

[s1monw]

@jpountz I think we can lose this now right?

[jpountz]

Closed via e589301. Releasable now extends AutoCloseable and can be used in try-with-resources.

[s1monw]

thx