Enforce query instance checking before it wrapper as a filter #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new QueryWrapperFilter(query); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need the factory or could its logic be directly implemented in Queries.wrap?
There was a problem hiding this comment.
that way I can exclude only this factor in the pom file from forbidden API checks - I can add a comment there!
|
+1 This is a more structured approach than the if/else in the place where QueryFilterWrapper was being used. |
We have the default QueryWrapperFilter as well as our custom one while our wrapper is explicitly marked as no_cache such that it will never be included in a cache. This was not consistenly used and caused several problems during tests where p/c related queries were used as filters and ended up in the cache. This commit adds the QueryWrapperFilter ctor to the forbidden APIs to enforce the query instance checks.
|
@jpountz @martijnvg I added two new commits see |
|
+1 to push |
|
pushed |
clintongormley
added
:Core/Infra/Transport API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the default QueryWrapperFilter as well as our custom one while
our wrapper is explicitly marked as no_cache such that it will never
be included in a cache. This was not consistenly used and caused several
problems during tests where p/c related queries were used as filters
and ended up in the cache. This commit adds the QueryWrapperFilter
ctor to the forbidden APIs to enforce the query instance checks.
Unfortunately this doesn't fix cases where such a query is nested in a BQ or so. Yet I want to fix it step by step but this one at least fixes some cases and prevents more misuse.