Fix cardinality memory-usage considerations. #5452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default precision was computed based on the number of MULTI_BUCKET parents instead of PER_BUCKET. The ordinals-based execution mode was almost always used although ordinals might have non-negligible memory usage compared to the counters. Close elastic#5452
| final long ordinalsMemoryUsage = OrdinalsCollector.memoryOverhead(maxOrd); | ||
| final long countsMemoryUsage = HyperLogLogPlusPlus.memoryUsage(precision); | ||
| // only use ordinals if they don't increase memory usage by more than 25% | ||
| if (ordinalsMemoryUsage < countsMemoryUsage / 4) {System.out.println("ORDS"); |
There was a problem hiding this comment.
I actually fixed it before pushing but forgot to commit. :-)
|
Nice - tested on my problem dataset/query and the memory use is significantly reduced. |
|
LGTM (I can see the confusion with the MULTI_BUCKET vs PER_BUCKET... I'm open to other names that might be more descriptive... (though not that simple to find those names ;)) |
jpountz
added a commit
that referenced
this pull request
Mar 20, 2014
Default precision was computed based on the number of MULTI_BUCKET parents instead of PER_BUCKET. The ordinals-based execution mode was almost always used although ordinals might have non-negligible memory usage compared to the counters. Close #5452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default precision was computed based on the number of MULTI_BUCKET parents
instead of PER_BUCKET.
The ordinals-based execution mode was almost always used although ordinals
might have non-negligible memory usage compared to the counters.