Context Suggester Issues/Exceptions

[spinscale]

The context suggester seems to have a couple of bugs in the geo impl - when working according to the docs I could not create working suggestions.

This example does not return any suggestions (but it should return the one in Amsterdam)

DELETE venues
PUT venues

GET venues/_mapping
PUT venues/poi/_mapping
{
  "poi" : {
    "properties" : {
      "suggest_field": {
        "type": "completion",
        "context": {
          "loc": { 
            "type": "geo",
            "precision" : "10km"
          }
        }
      }
    }
  }
}

PUT venues/poi/1
{
  "suggest_field": {
    "input": ["Hotel Amsterdam" ],
    "context": {
      "loc": {
        "lat": 52.529172, 
        "lon": 13.407333
      }
    }
  }
}

GET venues/poi/2
PUT venues/poi/2
{
  "suggest_field": {
    "input": ["Hotel Berlin in AMS" ],
    "context": {
      "loc": {
        "lat": 52.363389, 
        "lon": 4.888695
      }
    }
  }
}

GET /venues/_search

GET /venues/_suggest
{
  "suggest" : {
    "text" : "h",
    "completion" : {
      "field" : "suggest_field",
      "context": {
        "loc": {
          "lat": 52.36,
          "lon": 4.88
        }
      }
    }
  }
}

This returns a parsing exception (but is mentioned in the docs like that)

DELETE venues
PUT venues

GET venues/_mapping
PUT venues/poi/_mapping
{
  "poi" : {
    "properties" : {
      "suggest_field": {
        "type": "completion",
        "context": {
          "location": {
              "type": "geo",
              "precision": ["1km", "5m"],
              "neighbors": true,
              "path": "pin",
              "default": {
                  "lat": 0.0,
                  "lon": 0.0
              }
          }
        }
      }
    }
  }
}

This is also directly from the docs, using the value field, results in a parse exception

DELETE venues
PUT venues

GET venues/_mapping
PUT venues/poi/_mapping
{
  "poi" : {
    "properties" : {
      "suggest_field": {
        "type": "completion",
        "context": {
          "loc": { 
            "type": "geo",
            "precision" : "10km"
          }
        }
      }
    }
  }
}

GET /venues/_suggest
{
    "suggest" : {
        "text" : "m",
        "completion" : {

            "field" : "suggest_field",
            "size": 10,
            "context": {
                "location": {
                    "value": {

                        "lat": 0,
                        "lon": 0
                    },
                    "precision": "1km"
                }
            }
        }

    }
}

Also the category suggester seems to have an issue, when you specify a path in the mapping for the context, but that path is not set on document indexing

DELETE services
PUT services
PUT services/service/_mapping
{
    "service": {
        "properties": {
            "suggest_field": {
                "type": "completion",
                "context": {
                    "color": { 
                        "type": "category",
                        "path": "color_field"
                    }
                }
            }
        }
    }
}

GET services/service/_mapping

PUT services/service/1
{
    "suggest_field": {
        "input": ["knacksack", "backpack", "daypack"]
    }
}

This was tested on the 1.x branch and master