Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CountRequestBuilder toString() #5555

Closed
sangitabhagat opened this issue Mar 26, 2014 · 1 comment
Closed

CountRequestBuilder toString() #5555

sangitabhagat opened this issue Mar 26, 2014 · 1 comment
Assignees
@javanna
Labels
>enhancement

Comments

@sangitabhagat
Copy link

SearchRequestBuilder has a friendly toString method, but not same for CountRequestBuilder.
Will be a good to have feature for debugging.
@javanna javanna self-assigned this Mar 26, 2014
@javanna
Copy link
Member

javanna commented Mar 27, 2014

I agree it would be good to have, on the other hand looking at how the current toString works in SearchRequestBuilder I found #5576, which is probably even worse than not having the toString at all. I'll wait a bit to see what others think and see how we can fix that one and whether we can do the same here.

@GaelTadh GaelTadh assigned GaelTadh and unassigned javanna Aug 19, 2014
GaelTadh added a commit to GaelTadh/elasticsearch that referenced this issue Aug 19, 2014
@GaelTadh
[Fix] Add CountRequestBuilder.toString and fix SearchRequestBuilder.t…
8aa3ed1 
…oString

This commit fixes the SearchRequestBuilder.toString to be idempotent and adds an
idempotent CountRequestBuilder.toString method.
Also add tests for both these methods to prove the aren't mutating the underlying search request.

See elastic#5555 elastic#5576 elastic#7334
@GaelTadh GaelTadh mentioned this issue Oct 10, 2014
Closed
@javanna javanna assigned javanna and unassigned GaelTadh Mar 2, 2015
@javanna javanna mentioned this issue Mar 2, 2015
Closed
javanna added a commit to javanna/elasticsearch that referenced this issue Mar 7, 2015
@javanna
Java api: implement toString in CountRequestBuilder
f928727 
Similarly to what SearchRequestBuilder does, we print out a string representation of they query that is going to be executed when executing the request builder.

Closes elastic#5555
javanna added a commit to javanna/elasticsearch that referenced this issue Mar 13, 2015
@javanna
Java api: implement toString in CountRequestBuilder
e0f9ec6 
Similarly to what SearchRequestBuilder does, we print out a string representation of they query that is going to be executed when executing the request builder.

Closes elastic#5555
javanna added a commit to javanna/elasticsearch that referenced this issue Apr 28, 2015
@javanna
Java api: implement toString in CountRequestBuilder
e35a513 
Similarly to what SearchRequestBuilder does, we print out a string representation of the query that the count request builder holds.

Closes elastic#5555
javanna added a commit to javanna/elasticsearch that referenced this issue Apr 28, 2015
@javanna
Java api: implement toString in CountRequestBuilder
3c21f4e 
Similarly to what SearchRequestBuilder does, we print out a string representation of the query that the count request builder holds.

Closes elastic#5555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>enhancement
Projects
None yet
Milestone
No milestone
3 participants
@javanna @GaelTadh @sangitabhagat