Fix IndexShardRoutingTable's shard randomization to not throw out-of-bounds exceptions. #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bounds exceptions. Close elastic#5559
| final List<Object> rotated = CollectionUtils.rotate(list, size); | ||
| assertEquals(rotated.size(), list.size()); | ||
| assertEquals(Iterables.size(rotated), list.size()); | ||
| assertEquals(new HashSet<>(rotated), new HashSet<>(list)); |
There was a problem hiding this comment.
hmm I gues we should also test that the contents are the same here?
There was a problem hiding this comment.
grr nevermind I didn't see the last line pfff...
There was a problem hiding this comment.
one think that I think we should test is that the roation here is actually stable. It if you iterate the same list twice it has the same order?
There was a problem hiding this comment.
do you mean checking that rotating twice the same list gives the same output?
assertEquals(CollectionUtils.rotate(list, size), CollectionUtils.rotate(list, size));
|
this looks great - I left some commetns |
|
@s1monw I pushed a new commit |
|
LGTM |
|
Thanks Simon. |
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
May 5, 2014
Change elastic#5561 introduced a potential bug in that iterations that are performed on a thread are might not be visible to other threads due to the removal of the `volatile` keyword. Close elastic#6039
clintongormley
added
:Search/Search
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Change elastic#5561 introduced a potential bug in that iterations that are performed on a thread are might not be visible to other threads due to the removal of the `volatile` keyword. Close elastic#6039
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Change elastic#5561 introduced a potential bug in that iterations that are performed on a thread are might not be visible to other threads due to the removal of the `volatile` keyword. Close elastic#6039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially wanted to make the diff minimal but this ended up being quite complicated
so I finally refactored a bit the way shards are randomized. Yet, it uses the same logic:
Close #5559