Restore streamInput() performance over PagedBytesReference. #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while (written < len) { | ||
| b[bOffset + written] = bytearray.get(offset + written); | ||
| written++; | ||
| // how much can we bulk-read until hitting a multiple of PAGE_SIZE? |
There was a problem hiding this comment.
could you put the //comments behind the actual line - this would be much easier to read and we have 120 chars at least :)
|
Made args final, reformatted a bit, added PR. |
| long pagefragment = PAGE_SIZE - (bytearrayOffset % PAGE_SIZE); // how much can we read until hitting N*PAGE_SIZE? | ||
| int bulksize = (int)Math.min(pagefragment, todo - written); // we cannot copy more than a page fragment | ||
| boolean copied = bytearray.get(bytearrayOffset, bulksize, ref); // get the fragment | ||
| assert (copied == false); // we should never ever get back a materialized byte[] |
There was a problem hiding this comment.
this still confuses me why do we return that boolean if it is always expected to be false?
There was a problem hiding this comment.
I your reply got busted.... lemme reread
There was a problem hiding this comment.
The assert was just for testing. If you find it less confusing I can remove the return value & the assert .
There was a problem hiding this comment.
I am just wondering if we can make sure we never get a class taht does that but I guess the assert is ok
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation of bulk-reading a streamInput() over PagedBytesReference was slow (byte-by-byte reading when bulk copying).
Times in µs for bulk-reading a stream over plain vs. paged, averaged over 1000 runs:
This changeset restores performance:
The performance jitters slightly due to the usual Hotspot variances, OS scheduling etc. For all practical purposes the performance is now back to what it was before.