ContextSuggester: Adding couple of tests to catch more bugs #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +97,9 @@ public PrefixTokenFilter(TokenStream input, char separator, Iterable<? extends C | |||
| this.prefixes = prefixes; | |||
| this.currentPrefix = null; | |||
| this.separator = separator; | |||
| assert (prefixes != null && prefixes.iterator().hasNext()) : "one or more prefix needed"; | |||
| if (prefixes == null || !prefixes.iterator().hasNext()) { | |||
| throw new ElasticsearchException("one or more prefixes needed"); | |||
There was a problem hiding this comment.
can this be ElasticsearchIllegalArguementExcpetion?
|
I think this one looks good though I left two small comments |
|
LGTM |
A bunch of minor fixes have been included here, especially due to wrongly parsed mappings. Also using assertions resulted in an NPE because they were disabled in the distribution. Closes elastic#5525
clintongormley
added
>bug
v2.0.0-beta1
v1.2.0
:Search/Suggesters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of minor fixes have been included here, especially due
to wrongly parsed mappings. Also using assertions resulted in an
NPE because they were disabled in the distribution.
Closes #5525
Also, there is one last thing, which needs discussing: Currently the default precision is so accurate, that a suggestions will fail, you index the lat/lon
52.363389/4.888695but search with52.3633, 4.8886- I think this is confusing. We should either force people to set aprecisionin the mapping or have less high accuracy.