Search template: Put source param into template variable #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -423,8 +423,8 @@ public SearchRequest templateSource(BytesReference template, boolean unsafe) { | |||
| * The template of the search request. | |||
| */ | |||
| public SearchRequest templateSource(String source) { | |||
There was a problem hiding this comment.
May be we should change String source to String templateSource?
Just "cosmetic" change though... :)
|
++ Fixes my tests |
If a search template was created using the source parameter, the content of the parameter was put as source instead of sourceTemplate Fixes elastic#5556
clintongormley
added
>bug
v2.0.0-beta1
v1.2.0
v1.1.1
:Core/Infra/REST API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a search template was created using the source parameter, the
content of the parameter was put as source instead of sourceTemplate
Fixes #5556