Update CORS to respond with specific origin #5601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When put behind basic auth, CORS requests don't allow the use of
a wildcard ("*") for Access-Control-Allow-Origin:
http://www.w3.org/TR/cors/#resource-requests
This commit fixes that and responds directly with the requested
origin.
|
came here to submit this exact issue :) @kimchy, would you review this please? |
|
Was just about to make this pull request myself as well. This is the only way to have CORS with HTTP Basic authentication (without using a proxy). A big +1 from the Qbox.io team. |
|
we will review it, we are thinking about how to better handle CORS on a more broader sense, which will also do this, right @spinscale? |
|
Yeah, either way--I'm not too attached to the PR, so feel free to close! |
|
Hey there, I am going to supercede this one with a new PR for properly supporting CORS very soon also adding some more features. |
spinscale
added a commit
to spinscale/elasticsearch
that referenced
this pull request
Jul 25, 2014
This commit adds regular expression support for the allow-origin header depending on the value of the request `Origin` header. The existing HttpRequestBuilder is also extended to support the OPTIONS HTTP method. Relates elastic#5601 Closes elastic#6891
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When put behind basic auth, CORS requests don't allow the use of
a wildcard ("*") for Access-Control-Allow-Origin:
http://www.w3.org/TR/cors/#resource-requests
We ran into this while having nginx with basic auth proxy to our es
node. It should effectively be the same as what is there for CORS
requests, but respond with the origin. Happy to update for any
changes neccessary.