Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces usage of StringBuffer with StringBuilder #5606

Conversation

pickypg
Copy link
Member

@pickypg pickypg commented Mar 30, 2014

Closes #5605

Also fixes stray single quote in the same PluginInfo#toString() method.

single quote in the same `PluginInfo#toString()` method.

Closes elastic#5605
@javanna javanna self-assigned this Mar 31, 2014
@javanna
Copy link
Member

javanna commented Mar 31, 2014

Hi @pickypg , did you already sign our CLA? If not could you please do it so that we can merge your PRs?

@pickypg
Copy link
Member Author

pickypg commented Mar 31, 2014

I signed it already. Thanks.

-----Original Message-----
From: "Luca Cavanna" notifications@github.com
Sent: ‎3/‎31/‎2014 4:39 AM
To: "elasticsearch/elasticsearch" elasticsearch@noreply.github.com
Cc: "Chris Earle" pickypg@gmail.com
Subject: Re: [elasticsearch] Replaces usage of StringBuffer withStringBuilder (#5606)

Hi @pickypg , did you already sign our CLA? If not could you please do it so that we can merge your PRs?

Reply to this email directly or view it on GitHub.

@javanna
Copy link
Member

javanna commented Apr 1, 2014

Merged, thanks!

@javanna javanna closed this Apr 1, 2014
@pickypg pickypg deleted the feature/stringbuffer-to-stringbuilder-5605 branch April 1, 2014 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringBuilder should be used in place of StringBuffer
3 participants