Aggregations cleanup #5614
Closed
Aggregations cleanup #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uboness
commented
Mar 31, 2014
uboness
commented
- removed an abstraction layer that handles the values source (consolidated values source with field data source)
- better handling of value parser/formatter in range & histogram aggs
- the buckets key will now be shown by default in range agg
| @@ -96,7 +94,7 @@ public AggregatorFactory parse(String aggregationName, XContentParser parser, Se | |||
| shardSize = requiredSize; | |||
| } | |||
|
|
|||
| ValuesSourceConfig<GeoPointValuesSource> config = new ValuesSourceConfig<>(GeoPointValuesSource.class); | |||
| ValuesSourceConfig<ValuesSource.GeoPoint> config = new ValuesSourceConfig<ValuesSource.GeoPoint>(ValuesSource.GeoPoint.class); | |||
There was a problem hiding this comment.
Please don't undo the migration to the diamond operator. :-)
|
Is the change in the range agg backward compatible? I spotted a lines where you reverted the migration to the diamond operator but otherwise I really really like this change! |
|
@jpountz the change in the range agg should be bwc... the main thing there is the addition of the |
|
and sure... I'll give you back your diamonds |
|
Perfect! |
- removed an abstraction layer that handles the values source (consolidated values source with field data source) - better handling of value parser/formatter in range & histogram aggs - the buckets key will now be shown by default in range agg
|
closed by d6636fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.