Add getAsRatio to Settings class, allow DiskThresholdDecider to take percentages
#5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e percentages Adds new RatioValue class that parses ratios between 0-100% expressed in either floating-point (0.13) or percentage (51.12%) notation.
| /** | ||
| * Parses the provided string as a {@link RatioValue}, the string can | ||
| * either be in percentage format (eg. 73.5%), or a floating-point ratio | ||
| * format (eg. 0.112) |
There was a problem hiding this comment.
It'd be ever so slightly clearer if the two examples parsed to the same RaioValue. Like (eg. 73.5%) and (eg. .735).
There was a problem hiding this comment.
That's a good point, I'll update this javadoc for that.
|
LGTM |
dakrone
added a commit
that referenced
this pull request
Apr 4, 2014
…e percentages Adds new RatioValue class that parses ratios between 0-100% expressed in either floating-point (0.13) or percentage (51.12%) notation. Closes #5690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new RatioValue class that parses ratios between 0-100% expressed in
either floating-point (0.13) or percentage (51.12%) notation.