Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LongHash add/key not consistent #5693

Closed
mattweber opened this issue Apr 4, 2014 · 2 comments
Closed

LongHash add/key not consistent #5693

mattweber opened this issue Apr 4, 2014 · 2 comments
Labels
>enhancement v1.2.0 v2.0.0-beta1

Comments

@mattweber
Copy link
Contributor

LongHash seems to be buggy and does not work like BytesRefHash. Adds consistently fail and return an invalid index. Adding a value already in the hash does not return the expected values as well. I came across this working on #3278 where I had inconsistent number of terms in the LongHash. I adapted the BytesRefHash tests for LongHash and they consistently fail as well. See PR #5692 for the updated tests.
@mattweber
Copy link
Contributor Author

/cc @uboness @jpountz As I see you have worked on LongHash.

@mattweber
Copy link
Contributor Author

Updated the PR to include changes to LongHash so all tests pass.

mattweber added a commit to mattweber/elasticsearch that referenced this issue Apr 7, 2014
@mattweber
Update LongHash to work like BytesRefHash.
8f81586 
- rename "key" to "get"
- update and add more tests

Closes elastic#5693
jpountz pushed a commit that referenced this issue Apr 7, 2014
@mattweber @jpountz
Update LongHash to work like BytesRefHash.
e79cddf 
- rename "key" to "get"
- update and add more tests

Closes #5693
@jpountz jpountz closed this as completed in e3187d5 Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement v1.2.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @mattweber @jpountz