Rest layer refactoring phase 2 + recycling in http layer #5708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the rest layer handlers to simplify common code paths (like handling) failures, and introduce optional (enabled for netty) rest channel bytes recycling
|
This pull request is very unfortunate that it doesn't have multiple commits to show the individual steps. I am not even sure it could do that but it would have been awesome if it could have separated the handling of the errors and building responses as one commit and the recycling as another. I think we should land this quickly since it has a loooot of goodness... I will give a LGTM here and we should move it in VERY soon and let CI chew on it. |
|
removing the recycling is simple, a few lines change |
kimchy
changed the title
|
showed @s1monw the recycling part, I will push it with it, easy to disable if we need to afterwards |
kimchy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the rest layer handlers to simplify common code paths (like handling) failures, and introduce optional (enabled for netty) rest channel bytes recycling