clear scroll throws 500 on array out of bounds exception

[Mpdreamz]

DELETE http://127.0.0.1:9200/_search/scroll/asdasdadasdasd HTTP/1.1

Returns the following response

HTTP/1.1 500 Internal Server Error
Content-Type: application/json; charset=UTF-8
Content-Length: 73

{
  "error" : "ArrayIndexOutOfBoundsException[1]",
  "status" : 500
}

While a 404 is expected.

It would also be nice if we can allow the scroll id to be posted. I've had people hit problems with scroll ids that are too big in the past:

elastic/elasticsearch-net#318

[martijnvg]

@Mpdreamz Actually that specific scroll id is malformed and that is where the ArrayIndexOutOfBoundsException comes from, so I think a 400 should be returned?

If a non existent scroll_id is used, it will just return and act like everything is fine. I agree a 404 would be nice.

[clintongormley]

++404

[Mpdreamz]

++404 and +1 on implementing #5726 @martijnvg !

[martijnvg]

PR #5738 only addresses invalid scroll ids. Returning a 404 for a valid, but non existing scroll id requires more work than just validation. The clear scoll api uses an internal free search context api, which for example the search api relies on. This internal api just always returns an empty response. I can change that, so that it includes whether it actually has removed a search context, but that requires a change in the transport layer, so I like to do separate that in a different PR.

[s1monw]

LGTM

[s1monw]

@martijnvg can you assign the fix version here please

[martijnvg]

@s1monw PR #5738 only handles invalid scroll ids, but this issue is also about returning a 404 when a valid scroll id doesn't exist. I will assign the proper versions in PR and leave this issue open, once the missing scroll id has been addressed this issue can be closed.