A new ClusterStateStatus to indicate cluster state life cycles #5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ClusterService applies a new cluster state, it is first assigned as the new active one and then all listeners are called. Some of ES's features sample the current state and try to take action on it (for example index a document). If that fails, they will wait for change in the cluster state and try again (for example, wait for a shard to start and try indexing again). If you're unlucky you sample the state after it has been assigned as the "active" state but before all listeners has done the work. In this cases the action take (i.e., indexing a doc) will still fail (as the shard is not yet started) but waiting for a new state may take a long time or fail. This commit adds a new ClusterStateStatus that allows to better track the stages a cluster state goes through (currently `RECEIVED`, `BEING_APPLIED` & `APPLIED`). This allows detecting that a cluster state is not yet fully applied and retry without waiting for a new state to arrive. This commits also adds a utility class , ClusterStateObserver, to make this pattern slightly simpler and avoid common pit falls.
| */ | ||
| public class ClusterStateObserver { | ||
|
|
||
| protected final ESLogger logger = Loggers.getLogger(getClass()); |
There was a problem hiding this comment.
the logger here should either be static, or passed in the constructor (better, since it will have much more info)
There was a problem hiding this comment.
logger is now passed in the constructor.
|
I like this in general - I left some comments |
| }); | ||
| observer.waitForNextChange(new ClusterStateObserver.Listener() { | ||
| @Override | ||
| public void onNewClusterState(ClusterState state) { |
|
Thx all. Left some comments and pushed an update based on the feedback. |
|
this LGTM I think we should let our CI build chew on it a bit - boaz do you wanna open a enhancement/ branch? |
|
Thx. pushed this to enhance/cluster_state_status. |
bleskes
added a commit
that referenced
this pull request
Apr 22, 2014
When the ClusterService applies a new cluster state, it is first assigned as the new active one and then all listeners are called. Some of ES's features sample the current state and try to take action on it (for example index a document). If that fails, they will wait for change in the cluster state and try again (for example, wait for a shard to start and try indexing again). If you're unlucky you sample the state after it has been assigned as the "active" state but before all listeners has done the work. In this cases the action take (i.e., indexing a doc) will still fail (as the shard is not yet started) but waiting for a new state may take a long time or fail. This commit adds a new ClusterStateStatus that allows to better track the stages a cluster state goes through (currently `RECEIVED`, `BEING_APPLIED` & `APPLIED`). This allows detecting that a cluster state is not yet fully applied and retry without waiting for a new state to arrive. This commit also adds a utility class , ClusterStateObserver, to make this pattern slightly simpler and avoid common pit falls. Closes #5741
|
push. thx for the reviews. |
mikemccand
pushed a commit
to mikemccand/elasticsearch
that referenced
this pull request
Apr 24, 2014
When the ClusterService applies a new cluster state, it is first assigned as the new active one and then all listeners are called. Some of ES's features sample the current state and try to take action on it (for example index a document). If that fails, they will wait for change in the cluster state and try again (for example, wait for a shard to start and try indexing again). If you're unlucky you sample the state after it has been assigned as the "active" state but before all listeners has done the work. In this cases the action take (i.e., indexing a doc) will still fail (as the shard is not yet started) but waiting for a new state may take a long time or fail. This commit adds a new ClusterStateStatus that allows to better track the stages a cluster state goes through (currently `RECEIVED`, `BEING_APPLIED` & `APPLIED`). This allows detecting that a cluster state is not yet fully applied and retry without waiting for a new state to arrive. This commit also adds a utility class , ClusterStateObserver, to make this pattern slightly simpler and avoid common pit falls. Closes elastic#5741
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ClusterService applies a new cluster state, it is first assigned as the new active one and then all listeners are called. Some of ES's features sample the current state and try to take action on it (for example index a document). If that fails, they will wait for change in the cluster state and try again (for example, wait for a shard to start and try indexing again).
If you're unlucky you sample the state after it has been assigned as the "active" state but before all listeners has done the work. In this cases the action taken (i.e., indexing a doc) will still fail (as the shard is not yet started) but waiting for a new state may take a long time or timeout.
This commit adds a new ClusterStateStatus that allows to better track the stages a cluster state goes through (currently
RECEIVED,BEING_APPLIED&APPLIED). This allows detecting that a cluster state is not yet fully applied and retry without waiting for a new state to arrive.This commit also adds a utility class , ClusterStateObserver, to make this pattern slightly simpler and avoid common pit falls.