Prevent fsync from creating 0-byte files #5746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imotov if you have time I'd love if you could take a look at this again. I added a new commit that cleans up that writeBlob method and also tries to fsync the directory that we have written too. |
| if (innerSuccess) { | ||
| IOUtils.close(is, raf); | ||
| } else { | ||
| IOUtils.closeWhileHandlingException(is, raf); |
There was a problem hiding this comment.
There is now an unused import for IOUtils in this file.
|
LGTM |
| @@ -75,11 +80,7 @@ public static int maxOpenFiles(File testDir) { | |||
| } catch (IOException ioe) { | |||
| int i = 0; | |||
| for (RandomAccessFile raf : files) { | |||
There was a problem hiding this comment.
fyi I think you can IOUtils.closeWhileHandlingException(files) since its Iterable...
There was a problem hiding this comment.
true man I am going to remove this method anyway soon
|
+1 for the fsync fix, I'm glad we factored this logic into a utility method in Lucene 4.8.... |
This is related to LUCENE-5570 where fsync creates a 0-byte file if the file does not exists. This commit adds the patched lucene version using Java 7 APIs as well as a note to replace this method with the upcomeing IOUtils#fsync in Lucene 4.8 This commit cleans up FsImmutableBlobContainer#writeBlob to make use of Java7 Auto-Closing features and ensures that the directory the blob was written to is fsynced as well if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to LUCENE-5570 where fsync creates a 0-byte file
if the file does not exists. This commit adds the patched lucene
version using Java 7 APIs as well as a note to replace this method
with the upcomeing IOUtils#fsync in Lucene 4.8