Improved SearchContext.addReleasable. #5799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For resources that have their life time effectively defined by the search context they are attached to, it is convenient to use the search context to schedule the release of such resources. This commit changes aggregations to use this mechanism and also introduces a `Lifetime` object that can be used to define how long the object should live: - COLLECTION: if the object only needs to live during collection time and is what SearchContext.addReleasable would have chosen before this change (used for p/c queries), - SEARCH_PHASE for resources that only need to live during the current search phase (DFS, QUERY or FETCH), - SEARCH_CONTEXT for resources that need to live until the context is destroyed. Aggregators are currently registed with SEARCH_CONTEXT. The reason is that when using the DFS_QUERY_THEN_FETCH search type, they are allocated during the DFS phase but only used during the QUERY phase. However we should fix it in order to only allocate them during the QUERY phase and use SEARCH_PHASE as a life time. Close elastic#5703
| /** | ||
| * This life time is for objects that need to live until the end of the current search phase. | ||
| */ | ||
| SEARCH_PHASE, |
There was a problem hiding this comment.
maybe call them COLLECTION, PHASE, CONTEXT since they are true subsets?
|
I left some style issue comments but this looks very good! |
|
@s1monw I just pushed new commits |
|
LGTM |
clintongormley
added
>bug
v2.0.0-beta1
v1.2.0
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For resources that have their life time effectively defined by the search
context they are attached to, it is convenient to use the search context to
schedule the release of such resources.
This commit changes aggregations to use this mechanism and also introduces
a
Lifetimeobject that can be used to define how long the object shouldlive:
what SearchContext.addReleasable would have chosen before this change
(used for p/c queries),
phase (DFS, QUERY or FETCH),
destroyed.
Aggregators are currently registed with CONTEXT. The reason is that when
using the DFS_QUERY_THEN_FETCH search type, they are allocated during the DFS
phase but only used during the QUERY phase. However we should fix it in order
to only allocate them during the QUERY phase and use PHASE as a life
time.
Close #5703