Instantiate facets/aggregations during the QUERY phase. #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase. Today, if some shards pass the DFS phase but all of them fail the QUERY phase, the response will only consist of failed shards. We should throw an exception instead in order to be consistent with the QUERY_THEN_FETCH type.
In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently instantiated during the DFS phase while they only become useful during the QUERY phase. By instantiating during the QUERY phase instead, we can make better use of recycling since objects will have a shorter life out of the recyclers.
|
++ |
jpountz
added a commit
that referenced
this pull request
Apr 24, 2014
In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently instantiated during the DFS phase while they only become useful during the QUERY phase. By instantiating during the QUERY phase instead, we can make better use of recycling since objects will have a shorter life out of the recyclers. Close #5821
mikemccand
pushed a commit
to mikemccand/elasticsearch
that referenced
this pull request
Apr 24, 2014
In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently instantiated during the DFS phase while they only become useful during the QUERY phase. By instantiating during the QUERY phase instead, we can make better use of recycling since objects will have a shorter life out of the recyclers. Close elastic#5821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently
instantiated during the DFS phase while they only become useful during the QUERY
phase. By instantiating during the QUERY phase instead, we can make better use
of recycling since objects will have a shorter life out of the recyclers.