Use segment ordinals as global ordinals if possible #5873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues for a field on a shard level. Relates to elastic#5854
|
This looks good. I think we just need to make sure the mapping from segment ords to global ords for these segments isn't loaded into the cache. |
…l maxOrd, and use segment ordinals directly instead
|
Updated the PR and yes, that make absolutely sense, to save a bit more memory. |
| @@ -105,7 +105,7 @@ public InternalGlobalOrdinalsBuilder(Index index, @IndexSettings Settings indexS | |||
| breakerService.getBreaker().addWithoutBreaking(memorySizeInBytes); | |||
|
|
|||
| if (logger.isDebugEnabled()) { | |||
| String implName = segmentOrdToGlobalOrdLookups[0].getClass().getSimpleName(); | |||
| String implName = maxOrd < threshold ? "PackedIntOrdinalMappingSource" : "CompressedOrdinalMappingSource"; | |||
There was a problem hiding this comment.
Can we avoid hard-coding it?
There was a problem hiding this comment.
Agreed, this is ugly, I'll make it nice. In the current state segmentOrdToGlobalOrdLookups entries could be null (all of them), so that is why I resorted this hack.
| */ | ||
| public void initializeDocCounts(long maxOrd) { | ||
| docCounts = bigArrays.grow(docCounts, maxOrd); | ||
| } |
There was a problem hiding this comment.
Is it necessary? the aggregator factory should create it with the right size directly? (if it does not I think this is a bug)
martijnvg
added a commit
that referenced
this pull request
Apr 25, 2014
…rmsAggregator.WithHash impl. Relates #5873
martijnvg
added a commit
that referenced
this pull request
Apr 25, 2014
…rmsAggregator.WithHash impl. Relates #5873
martijnvg
deleted the
improvements/use-segment-ordinals-as-global-ordinals-if-all-values-exists-in-segment
branch
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use segment ordinals as global ordinals if a segment contains all values for a field on a shard level.
PR for #5854