Update default precision step, modulo tests #5908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,16 @@ org.apache.lucene.index.IndexWriter#forceMergeDeletes(boolean) @ use Merges#forc | |||
| @defaultMessage QueryWrapperFilter is cachable by default - use Queries#wrap instead | |||
| org.apache.lucene.search.QueryWrapperFilter#<init>(org.apache.lucene.search.Query) | |||
|
|
|||
| @defaultMessage Pass the precision step from the mappings explicitly instead | |||
| org.apache.lucene.search.NumericRangeQuery#newDoubleRange(java.lang.String,java.lang.Double,java.lang.Double,boolean,boolean) | |||
There was a problem hiding this comment.
man those seem to be trappy - maybe we should deprecate them in Lucene as well?
There was a problem hiding this comment.
|
I left some comments - looks good to me so far.... |
added 3 commits
April 22, 2014 18:44
…of what precision_step is
… fieldtype (for futureproofing)
|
OK, I think this is ready. One change i made: was to actually set the precisionStep in the fieldType passed to Lucene. This was just for consistency, so if something like https://issues.apache.org/jira/browse/LUCENE-5605 happens, it wont break. |
|
LGTM please squash and push to |
clintongormley
added
>enhancement
v2.0.0-beta1
v1.2.0
:Search/Mapping
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5905