Use Lucene built-in checksumming #5924
Assignees
Labels
:Core/Infra/Core
Core issues without another label
>enhancement
release highlight
resiliency
v1.3.0
v2.0.0-beta1
Comments
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this issue
Jul 7, 2014
Since Lucene version 4.8 each file has a checksum written as it's footer. We used to calculate the checksums for all files transparently on the filesystem layer (Directory / Store) which is now not necessary anymore. This commit makes use of the new checksums in a backwards compatible way such that files written with the old checksum mechanism are still compared against the corresponding Alder32 checksum while newer files are compared against the Lucene build in CRC32 checksum. Since now every written file is checksummed by default this commit also verifies the checksum for files during recovery and restore if applicable. Closes elastic#5924
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this issue
Jul 7, 2014
Since Lucene version 4.8 each file has a checksum written as it's footer. We used to calculate the checksums for all files transparently on the filesystem layer (Directory / Store) which is now not necessary anymore. This commit makes use of the new checksums in a backwards compatible way such that files written with the old checksum mechanism are still compared against the corresponding Alder32 checksum while newer files are compared against the Lucene build in CRC32 checksum. Since now every written file is checksummed by default this commit also verifies the checksum for files during recovery and restore if applicable. Closes elastic#5924
s1monw
added a commit
that referenced
this issue
Jul 8, 2014
Since Lucene version 4.8 each file has a checksum written as it's footer. We used to calculate the checksums for all files transparently on the filesystem layer (Directory / Store) which is now not necessary anymore. This commit makes use of the new checksums in a backwards compatible way such that files written with the old checksum mechanism are still compared against the corresponding Alder32 checksum while newer files are compared against the Lucene build in CRC32 checksum. Since now every written file is checksummed by default this commit also verifies the checksum for files during recovery and restore if applicable. Closes #5924
s1monw
added a commit
that referenced
this issue
Jul 8, 2014
Since Lucene version 4.8 each file has a checksum written as it's footer. We used to calculate the checksums for all files transparently on the filesystem layer (Directory / Store) which is now not necessary anymore. This commit makes use of the new checksums in a backwards compatible way such that files written with the old checksum mechanism are still compared against the corresponding Alder32 checksum while newer files are compared against the Lucene build in CRC32 checksum. Since now every written file is checksummed by default this commit also verifies the checksum for files during recovery and restore if applicable. Closes #5924
s1monw
added a commit
that referenced
this issue
Jul 9, 2014
Since Lucene version 4.8 each file has a checksum written as it's footer. We used to calculate the checksums for all files transparently on the filesystem layer (Directory / Store) which is now not necessary anymore. This commit makes use of the new checksums in a backwards compatible way such that files written with the old checksum mechanism are still compared against the corresponding Alder32 checksum while newer files are compared against the Lucene build in CRC32 checksum. Since now every written file is checksummed by default this commit also verifies the checksum for files during recovery and restore if applicable. Closes #5924
s1monw
added a commit
that referenced
this issue
Jul 10, 2014
Since Lucene version 4.8 each file has a checksum written as it's footer. We used to calculate the checksums for all files transparently on the filesystem layer (Directory / Store) which is now not necessary anymore. This commit makes use of the new checksums in a backwards compatible way such that files written with the old checksum mechanism are still compared against the corresponding Alder32 checksum while newer files are compared against the Lucene build in CRC32 checksum. Since now every written file is checksummed by default this commit also verifies the checksum for files during recovery and restore if applicable. Closes #5924 This commit also has a fix for #6808 since the added tests in `CorruptedFileTest.java` exposed the issue. Closes #6808
s1monw
added a commit
that referenced
this issue
Jul 10, 2014
Since Lucene version 4.8 each file has a checksum written as it's footer. We used to calculate the checksums for all files transparently on the filesystem layer (Directory / Store) which is now not necessary anymore. This commit makes use of the new checksums in a backwards compatible way such that files written with the old checksum mechanism are still compared against the corresponding Alder32 checksum while newer files are compared against the Lucene build in CRC32 checksum. Since now every written file is checksummed by default this commit also verifies the checksum for files during recovery and restore if applicable. Closes #5924 This commit also has a fix for #6808 since the added tests in `CorruptedFileTest.java` exposed the issue. Closes #6808
s1monw
added a commit
that referenced
this issue
Jul 14, 2014
We have to mark a shard as corrupted if necessary before the shard failed event is fired ie. before we call the corresponding listener in the engine. Otherwise the shard might be re-allocated on the same node and just started up without being marked as corrupted. Relates to #5924
s1monw
added a commit
that referenced
this issue
Jul 14, 2014
We have to mark a shard as corrupted if necessary before the shard failed event is fired ie. before we call the corresponding listener in the engine. Otherwise the shard might be re-allocated on the same node and just started up without being marked as corrupted. Relates to #5924
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lucene 4.8 added checksumming for all files using
CRC32. We useAdlerat this point on top of the Direcotory API to check integrity on recovery etc. We should try to cut over to the lucene impl since it comes "for free" now.The text was updated successfully, but these errors were encountered: