New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dynamic scripting by default #5943
Disable dynamic scripting by default #5943
Conversation
Added some commits adding a |
cool stuff
|
@s1monw good ideas! I've added both changes. The |
LGTM |
@@ -200,6 +200,7 @@ public TestCluster(long clusterSeed, int minNumNodes, int maxNumNodes, String cl | |||
builder.put("path.data", dataPath.toString()); | |||
} | |||
} | |||
builder.put("script.disable_dynamic", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be set to true to disable scripts by default? like the pull request states?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since scripting is disabled by default, we re-enable it back when we start each node in our test infrastructure, just because we have quite some tests that need it on. We are thinking about re-enabling it only for the tests that rely on it though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javanna thank you that helps a lot.
Also modifies the documentation for this, adding an example of using a preloaded script.
Closes #5853