Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fielddata: Switch to the Lucene comparators #5980

Closed
jpountz opened this issue Apr 29, 2014 · 2 comments
Closed

Fielddata: Switch to the Lucene comparators #5980

jpountz opened this issue Apr 29, 2014 · 2 comments
Labels
>enhancement v1.4.0.Beta1 v2.0.0-beta1

Comments

@jpountz
Copy link
Contributor

jpountz commented Apr 29, 2014

Now that ordinals have been made consistent with Lucene, we should remove our custom comparators and use the Lucene ones.
@mikemccand
Copy link
Contributor

+1

@clintongormley
Copy link

Bumping to 1.4

jpountz added a commit to jpountz/elasticsearch that referenced this issue Jul 23, 2014
@jpountz
Fielddata: goodbye comparators.
9f7830e 
This commit removes custom comparators in favor of the ones that are in Lucene.

The major change is for nested documents: instead of having a comparator wrapper
that deals with nested documents, this is done at the fielddata level by having
a selector that returns the value to use for comparison.

Sorting with custom missing string values might be slower since it is using
TermValComparator since Lucene's TermOrdValComparator only supports sorting
missing values first or last. But other than this particular case, this change
will allow us to benefit from improvements on comparators from the Lucene side.

Close elastic#5980
@jpountz jpountz mentioned this issue Jul 23, 2014
Closed
jpountz added a commit that referenced this issue Jul 23, 2014
@jpountz
Fielddata: goodbye comparators.
12ee48c 
This commit removes custom comparators in favor of the ones that are in Lucene.

The major change is for nested documents: instead of having a comparator wrapper
that deals with nested documents, this is done at the fielddata level by having
a selector that returns the value to use for comparison.

Sorting with custom missing string values might be slower since it is using
TermValComparator since Lucene's TermOrdValComparator only supports sorting
missing values first or last. But other than this particular case, this change
will allow us to benefit from improvements on comparators from the Lucene side.

Close #5980
@jpountz jpountz changed the title Switch to the Lucene comparators Fielddata: Switch to the Lucene comparators Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fielddata: Remove custom comparators and use Lucene's instead jpountz/elasticsearch
3 participants
@clintongormley @jpountz @mikemccand