Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of readerGen in BytesRefOrdValComparator on nested documents. #5986

Closed
wants to merge 1 commit into from

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Apr 29, 2014

Sorting was broken on nested documents because the missing(slot) method
didn't correctly set the segment ordinal (readerGen), causing term ordinals to
be compared across segments.

…nts.

Sorting was broken on nested documents because the `missing(slot)` method
didn't correctly set the segment ordinal (readerGen), causing term ordinals to
be compared across segments.
@jpountz jpountz changed the title Fix setting of readerGen in BytesRefOrdValComparator on nested documents... Fix setting of readerGen in BytesRefOrdValComparator on nested documents. Apr 29, 2014
@jpountz jpountz added v2.0.0 and removed v1.3.0 labels Apr 29, 2014
jpountz added a commit that referenced this pull request Apr 30, 2014
…nts.

Sorting was broken on nested documents because the `missing(slot)` method
didn't correctly set the segment ordinal (readerGen), causing term ordinals to
be compared across segments.

Close #5986
jpountz added a commit that referenced this pull request Apr 30, 2014
…nts.

Sorting was broken on nested documents because the `missing(slot)` method
didn't correctly set the segment ordinal (readerGen), causing term ordinals to
be compared across segments.

Close #5986
@jpountz jpountz closed this in 2eeaa56 Apr 30, 2014
jpountz added a commit that referenced this pull request Apr 30, 2014
…nts.

Sorting was broken on nested documents because the `missing(slot)` method
didn't correctly set the segment ordinal (readerGen), causing term ordinals to
be compared across segments.

Close #5986
@jpountz jpountz deleted the fix/comparator_reader_gen branch April 30, 2014 06:51
@clintongormley clintongormley added the :Search/Search Search-related issues that do not fall into other categories label Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
…nts.

Sorting was broken on nested documents because the `missing(slot)` method
didn't correctly set the segment ordinal (readerGen), causing term ordinals to
be compared across segments.

Close elastic#5986
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
…nts.

Sorting was broken on nested documents because the `missing(slot)` method
didn't correctly set the segment ordinal (readerGen), causing term ordinals to
be compared across segments.

Close elastic#5986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker >bug :Search/Search Search-related issues that do not fall into other categories v1.0.4 v1.1.2 v1.2.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants