Lower the initial sizing of sub aggregations. #5994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently compute initial sizings based on the cardinality of our fields. This can be highly exagerated for sub aggregations, for example if there is a parent terms aggregation that is executed over a field that has a very long tail: most buckets will only collect a couple of documents. Close elastic#5994
| @@ -25,6 +26,16 @@ | |||
| */ | |||
| public abstract class AggregatorFactory { | |||
|
|
|||
| protected static boolean hasParentBucketAggregator(Aggregator parent) { | |||
There was a problem hiding this comment.
doesn't feel like it belongs to the factory... why not put it in the Aggregator class?
There was a problem hiding this comment.
This utility method is only useful to factories though?
There was a problem hiding this comment.
Putting it on the Aggregator class would require to make it public.
There was a problem hiding this comment.
I don't see any problem with making it public
|
@uboness I just pushed a new commit to address your comments |
|
LGTM! |
jpountz
added a commit
that referenced
this pull request
May 6, 2014
We currently compute initial sizings based on the cardinality of our fields. This can be highly exagerated for sub aggregations, for example if there is a parent terms aggregation that is executed over a field that has a very long tail: most buckets will only collect a couple of documents. Close #5994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently compute initial sizings based on the cardinality of our fields.
This can be highly exagerated for sub aggregations, for example if there is a
parent terms aggregation that is executed over a field that has a very long
tail: most buckets will only collect a couple of documents.