Add /_cat/fielddata to display fielddata usage #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the code looks good, yea, this is the first time we have dynamic headers, but I think it makes sense in this context, maybe @clintongormley can chip in on the test / the fact that the headers are dynamic. |
|
|
||
| - match: | ||
| $body: | | ||
| /^total [\n0b ]+8\.4kb[\n0b ]+$/ |
There was a problem hiding this comment.
The main issue are whitespaces, we use the Pattern.COMMENTS flag to make regexes more readable, which means that you have to be explicit with whitespaces and use \s as the ' ' are ignored.
I got the following regex to work, changed the indendation too:
/^ total \s \n
(\s+0b \s \n)*
8\.4kb \s \n
(\s+0b \s \n)* $/
There was a problem hiding this comment.
Okay, thanks for the explanation, I committed a change to use your regex.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently has a disabled REST test, I'm not yet sure why the regular expression doesn't match.
The output is a little different because it has a dynamic number of columns depending on the number of fields, so if anyone has an alternative output format suggestion that would be great.
Closes #4593