MetaData#concreteIndices to throw exception with a single index argument if allowNoIndices == false #6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… argument in case allowNoIndices == false and ignoreUnavailable == true Closes elastic#6137
| */ | ||
| public boolean expandWildcardsOpen() { | ||
| return (id & 4) != 0; | ||
| } | ||
|
|
||
| /** | ||
| * @return Whether wildcard indices expressions should expanded into closed indices should be | ||
| * @return Whether wildcard expressions should get expanded ato closed indices |
There was a problem hiding this comment.
thanks for catching this :)
|
LGTM |
javanna
added a commit
that referenced
this pull request
May 12, 2014
… argument in case allowNoIndices == false and ignoreUnavailable == true Closes #6137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed MetaData#concreteIndices to throw exception with a single index argument in case allowNoIndices == false and ignoreUnavailable == true.
The current behaviour is inconsistent as 2 or more non existing indices would cause an exception to be thrown:
On the other hand
returns 0 results and no exception regardless of the
allow_no_indicesvalue.Took also the chance to improve the javadocs for
IndicesOptionsclass.