Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced exclude with include to avoid double negation #6248

Merged
merged 1 commit into from May 21, 2014
Merged

Replaced exclude with include to avoid double negation #6248

merged 1 commit into from May 21, 2014

Conversation

alexksikes
Copy link
Contributor

No description provided.

@jpountz
Copy link
Contributor

jpountz commented May 21, 2014

The change looks good but backward-incompatible. So I think this should only go to 2.0 and be added to the list of backward-compatibility breaks?

@s1monw
Copy link
Contributor

s1monw commented May 21, 2014

I think we can make this for 1.3 if we support both and drop the documentation for exclude! I like this muuch better! in master we can then drop the BW compat entirely

@alexksikes alexksikes removed the v1.3.0 label May 21, 2014
@alexksikes alexksikes merged commit a29b4a8 into elastic:master May 21, 2014
@jpountz
Copy link
Contributor

jpountz commented May 22, 2014

@alexksikes Do you plan to merge the change to the 1.x branch?

alexksikes added a commit to alexksikes/elasticsearch that referenced this pull request May 22, 2014
@alexksikes
More Like This Query: replaced 'exclude' with 'include' to avoid doub…
31b8406 
…le negation when set.

'exclude' is now marked as deprecated.

Closes elastic#6248
This was referenced May 22, 2014
Closed
Closed
@alexksikes
Copy link
Contributor Author

BW compat is covered by #6275 and merged with 1.x.

@clintongormley clintongormley changed the title More Like This Query: replaced 'exclude' with 'include' to avoid double ... Replaced exclude with include to avoid double negation Jun 7, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :More Like This labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexksikes @jpountz @s1monw @clintongormley