XFilteredQuery default strategy prefers query first in the deleted docs ... #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +66,15 @@ public String toString() { | |||
| return filter.toString(); | |||
| } | |||
|
|
|||
| public static DocIdSet unwarp(DocIdSet docIdSet) { | |||
|
pushed a cleanup commit |
|
LGTM |
|
+1 |
…cs case Today we check if the DocIdSet we filter by is `fast` but the check fails if the DocIdSet if wrapped in an `ApplyAcceptedDocsFilter` which is always the case if the index has deleted documents. This commit unwraps the original DocIdSet in the case of deleted documents. Closes elastic#6247
clintongormley
added
>bug
v2.0.0-beta1
v1.2.0
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...case
Today we check if the DocIdSet we filter by is
fastbut the check failsif the DocIdSet if wrapped in an
ApplyAcceptedDocsFilterwhich is alwaysthe case if the index has deleted documents. This commit unwraps
the original DocIdSet in the case of deleted documents.
Closes #6247