Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github download link when using specific version #6321

Closed
wants to merge 1 commit into from

Conversation

brusic
Copy link
Contributor

@brusic brusic commented May 28, 2014

Removes the extraneous 'v' character which could have been used previously for Github links.

Does not include an updated test case since the PluginManagerTests class skips tests with invalid downloads (try-catch block in singlePluginInstallAndRemove). In addition, the PluginManager logs to System.out, which is removed during tests.

@dadoonet dadoonet self-assigned this Jun 3, 2014
@dadoonet
Copy link
Member

dadoonet commented Jul 3, 2014

Thanks @brusic

Actually the v was used by elasticsearch when github was the download repo.
I agree that it does not make sense anymore.

Pushed in 1.2, 1.x and master branches.

@dadoonet dadoonet closed this Jul 3, 2014
@clintongormley clintongormley changed the title Fix github download link when using specific version Plugins: Fix github download link when using specific version Jul 9, 2014
@clintongormley clintongormley added :Core/Infra/Plugins Plugin API and infrastructure :Index Templates and removed :Index Templates labels Jun 7, 2015
@clintongormley clintongormley changed the title Plugins: Fix github download link when using specific version Fix github download link when using specific version Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants