Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update documentation on pull request policy #6323

Closed
nik9000 opened this issue May 28, 2014 · 0 comments
Closed

[docs] Update documentation on pull request policy #6323

nik9000 opened this issue May 28, 2014 · 0 comments
Assignees
Labels
>docs General docs changes

Comments

@nik9000
Copy link
Member

nik9000 commented May 28, 2014

After talking to some Elasticsearch folks they mentioned that they now like pull requests to be made up of multiple commits rather then amending the same commit. Before the pull request is merged it'd be squashed but during review it'd keep growing.

It'd be cool to document this on CONTRIBTUING.md and http://www.elasticsearch.org/contributing-to-elasticsearch/ .

If Elasticsearch grows pull request guidelines then can we add: always make the subject of your pull request descriptive of what it does rather then what issue it closes. These subjects turn into email subjects and it is a lot easier to filter what you need to read if the subject is descriptive like "Splort the sort sprocket to make the sort faster" or "Fix overflow in the foo" then "Closes #1234".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

No branches or pull requests

3 participants