Ensure internal scope extrators are always operating on a Map #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void testSearchRequestFail() throws Exception { | ||
| SearchRequest searchRequest = new SearchRequest(); | ||
| searchRequest.indices("_all"); | ||
| { |
There was a problem hiding this comment.
why this opening bracket here and the closing one in line 186? Apart from that LGTM
There was a problem hiding this comment.
because I like to use this to structure things in tests.
Mustache extracts the key/value pairs for parameter substitution from objects and maps but it's decided on the first execution. We need to make sure if the params are null we pass an empty map to ensure we bind the map based extractor Closes elastic#6318
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mustache extracts the key/value pairs for parameter substitution from
objects and maps but it's decided on the first execution. We need to
make sure if the params are null we pass an empty map to ensure we
bind the map based extractor
Closes #6318