New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added caching support to geohash_filter #6478
Conversation
I don't think we should cache this by default. It's very unlikely that you have cache hits here. In-fact this filter should rather not be cached at all and never be turned into a big bitset since this fitlter is likely going to be very fast (it's really just 9 terms after all?) I am not sure if we should do this? |
+1 to add the ability to cache it |
I'm a bit on the fence regarding the default - I was triggered to add it by someone using the geohash_cell filter as the fastest way to limit the result to a certain area. They were using level 4 with neighbours which translates to 120KM by 60KM box and put it under a bool filter which causes it to generate a bit set anyway. Maybe cache by default on level 4 or up? I don't have a good grip on the different usages of the geohash_cell filter, so if the people fill it shouldn't be cached, I'm good with that. Let me know. |
yeah I'd let the user decide ie. follow @jpountz suggestions. |
kk. Pushed another commit with the cache turned off + added cache/cachekey params to the java builder. |
@s1monw pushed another commit with an extra test |
LGTM ;) |
Caching is turned off by default. Closes #6478
No description provided.