Refactored AckedClusterStateUpdateTask & co. to remove code repetitions in subclasses #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns in subclasses Made AckedClusterStateUpdateTask an abstract class instead of an interface, which contains the common methods. Also introduced the AckedRequest interface to mark both AcknowledgedRequest & ClusterStateUpdateRequest so that the different ways of updating the cluster state (with or without a MetaData*Service) can share the same code. Removed ClusterStateUpdateListener as we can just use its base class ActionListener instead.
|
Nice stats! LGTM. |
|
LGTM |
javanna
added a commit
that referenced
this pull request
Jun 20, 2014
…ns in subclasses Made AckedClusterStateUpdateTask an abstract class instead of an interface, which contains the common methods. Also introduced the AckedRequest interface to mark both AcknowledgedRequest & ClusterStateUpdateRequest so that the different ways of updating the cluster state (with or without a MetaData*Service) can share the same code. Removed ClusterStateUpdateListener as we can just use its base class ActionListener instead. Closes #6559
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
AckedClusterStateUpdateTaskan abstract class instead of an interface, which contains the common methods.Also introduced the
AckedRequestinterface to mark bothAcknowledgedRequest&ClusterStateUpdateRequestso that the different ways of updating the cluster state (with or without aMetaData*Service) can share the same code.Removed
ClusterStateUpdateListeneras we can just use its base classActionListenerinstead.