Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise proper failure if not fully reading translog entry #6562

Closed
wants to merge 1 commit into from
Closed

Raise proper failure if not fully reading translog entry #6562

wants to merge 1 commit into from

Conversation

kimchy
Copy link
Member

@kimchy kimchy commented Jun 19, 2014

When reading a translog entry, raise a proper error when not reading it fully.

@kimchy
Raise proper failure if not fully reading translog entry
6438965 
When reading a translog entry, raise a proper error when not reading it fully.
close elastic#6562
@areek areek assigned rmuir and unassigned rmuir Jun 23, 2014
@s1monw
Copy link
Contributor

s1monw commented Jun 24, 2014

is there a chance to put the read method into forbidden APIs and have a helper that is allowed to read it that also checks for completeness?

@s1monw s1monw removed the review label Jun 24, 2014
@bleskes
Copy link
Contributor

bleskes commented Jun 24, 2014

I think this PR is superseded by #6576 and can be closed no?

@kimchy
Copy link
Member Author

kimchy commented Jun 24, 2014

@bleskes yes it can!, closing

@kimchy kimchy closed this Jun 24, 2014
@kimchy kimchy deleted the verify_translog_read branch June 24, 2014 13:03
@clintongormley clintongormley changed the title Raise proper failure if not fully reading translog entry Resiliency: Raise proper failure if not fully reading translog entry Jul 16, 2014
@clintongormley clintongormley changed the title Resiliency: Raise proper failure if not fully reading translog entry Raise proper failure if not fully reading translog entry Jun 7, 2015
@clintongormley clintongormley added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. and removed :Translog :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >enhancement resiliency v1.3.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kimchy @s1monw @bleskes @clintongormley @rmuir