Recovery API should also report ongoing relocation recoveries #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only report relocation related recoveries after they are done.
| ensureGreen(); | ||
|
|
||
| logger.info("--> slowing down recoveries"); | ||
| assertTrue(client().admin().cluster().prepareUpdateSettings().setTransientSettings("max_bytes_per_sec: 1").get().isAcknowledged()); |
There was a problem hiding this comment.
I think you set the wrong setting here? it needs to be indices.recovery.max_bytes_per_sec (there is a constant for it (RecoverySettings#INDICES_RECOVERY_MAX_BYTES_PER_SEC). Also, much nicer to set using the explicitly settings object I would say.
|
LGTM, except for that slowdown recovery settings question |
bleskes
added a commit
that referenced
this pull request
Jun 28, 2014
We currently only report relocation related recoveries after they are done. Closes #6585
clintongormley
changed the title
clintongormley
added
the
:Data Management/Stats
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only report relocation related recoveries after they are done.